Update Jest dependency + drop testing on Node 6 #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
changed the title
|
@evilebottnawi Is this acceptable (as opposed to #438 (comment) and so on)? If it is, someone will need to turn off the requirement for node-6 checks in the repo's settings. |
alexander-akait
requested changes
Mar 31, 2020
Fair, @evilebottnawi – that's basically what I did in #438. Audit is part of the lint step, which is also a required check. Would you like me to fully remove the audit from the lint step? |
|
Just ignore it, problems with audit will be resolved in near future |
|
Done in master, thanks for the PR, ETA - next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
CI had been broken due to npm audit problems. This should fix it.
However, the new version of Jest here isn't compatible with Node 6, so testing on it must be dropped.
In addition, it took some package-lock hacking to fix the one remaining low-priority problem in optimist (which might be fixed any day now, see handlebars-lang/handlebars.js#1661)...
Closes #438
Closes #439