Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement #406

Merged
merged 2 commits into from Nov 5, 2019
Merged

Performance improvement #406

merged 2 commits into from Nov 5, 2019

Commits on Nov 1, 2019

  1. Performance improvement 

    Sets don't allow duplicates, so checking for `has` is not necessary

webpack 5 makes these Sets lazy, which makes reading more expensive.
So only the watcher should read from these Sets, which is called after the compilation has finished,
so that doesn't contribute to build performance.

LazySets also have a `addAll` method, which allows to add an Iterable lazily (only iterated when LazySet is read)
    @sokra
    sokra committed Nov 1, 2019
    Copy the full SHA
    61cf57b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. Merge branch 'master' into perf/dependencies

    @evilebottnawi
    evilebottnawi committed Nov 5, 2019
    Copy the full SHA
    cdb3cbd View commit details
    Browse the repository at this point in the history