Improve clarity on how plugin works with built files #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that copy-webpack-plugin is designed to copy files _outside_ of the build process, rather than copy files _created by_ the build process. See: webpack-contrib#261 If one uses webpack-copy-plugin to try and copy a built file, if the file did not exist already, then the developer may receive a `WARNING in unable to locate` message, and the file is not correctly copied. This can cause some weird behaviour, especially because if you run webpack again, it will work fine (because it's copied over the previously built file). I would like to suggest adding in this documentation to the README to prevent people from using the plugin when it's not appropriate for their needs.
|
|
|
Can you create minimum reproducible test repo, looks like a bug |
|
The minimum reproducible thing is:
The first time you run webpack, dist/index.js doesn't exist, so I get a warning that the file doesn't exist. The second time, as long as you haven't cleaned out dist/, the (old) file is copied fine. |
|
Sorry for delay, see what you mean, you let's merge this in docs |
|
Close in #395, thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that copy-webpack-plugin is designed to copy files outside of the build process, rather than copy files created by the build process. See: #261
If one uses webpack-copy-plugin to try and copy a built file, if the file did not exist already, then the developer may receive a
WARNING in unable to locatemessage, and the file is not correctly copied. This can cause some weird behaviour, especially because if you run webpack again, it will work fine (because it's copied over the previously built file).I would like to suggest adding in this documentation to the README to prevent people from using the plugin when it's not appropriate for their needs.
This PR contains a:
Motivation / Use-Case
Breaking Changes
Additional Info