refactor: migrate on Set (#331)

webpack-contrib · Feb 18, 2019 · e870664 · e870664
1 parent 9e1c35e
commit e870664
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/src/index.js b/src/index.js
@@ -54,8 +54,8 @@ class CopyPlugin {
       log(msg, 2);
     }
 
-    const fileDependencies = [];
-    const contextDependencies = [];
+    const fileDependencies = new Set();
+    const contextDependencies = new Set();
     const written = {};
 
     let context;

diff --git a/src/postProcessPattern.js b/src/postProcessPattern.js
@@ -32,7 +32,7 @@ export default function postProcessPattern(globalRef, pattern, file) {
 
     // If this came from a glob, add it to the file watchlist
     if (pattern.fromType === 'glob') {
-      fileDependencies.push(file.absoluteFrom);
+      fileDependencies.add(file.absoluteFrom);
     }
 
     info(`reading ${file.absoluteFrom} to write to assets`);

diff --git a/src/preProcessPattern.js b/src/preProcessPattern.js
@@ -117,7 +117,7 @@ export default function preProcessPattern(globalRef, pattern) {
       }
 
       if (stats.isDirectory()) {
-        contextDependencies.push(pattern.absoluteFrom);
+        contextDependencies.add(pattern.absoluteFrom);
 
         pattern.fromType = 'dir';
         pattern.context = pattern.absoluteFrom;
@@ -127,7 +127,7 @@ export default function preProcessPattern(globalRef, pattern) {
           dot: true,
         };
       } else if (stats.isFile()) {
-        fileDependencies.push(pattern.absoluteFrom);
+        fileDependencies.add(pattern.absoluteFrom);
 
         pattern.fromType = 'file';
         pattern.context = path.dirname(pattern.absoluteFrom);

diff --git a/src/processPattern.js b/src/processPattern.js
@@ -45,11 +45,8 @@ export default function processPattern(globalRef, pattern) {
           // a new file is added it triggeres a rebuild
           const contextPath = path.dirname(path.resolve(from));
 
-          if (
-            contextDependencies.indexOf(contextPath) === -1 &&
-            isGlob(pattern.glob)
-          ) {
-            contextDependencies.push(contextPath);
+          if (isGlob(pattern.glob)) {
+            contextDependencies.add(contextPath);
           }
 
           debug(`found ${from}`);