Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aerial screensaver for webOS #103

Merged
merged 4 commits into from
May 30, 2024
Merged

Aerial screensaver for webOS #103

merged 4 commits into from
May 30, 2024

Conversation

aabytt
Copy link
Contributor

@aabytt aabytt commented May 12, 2024

No description provided.

Copy link

github-actions bot commented May 12, 2024

Check Results for webos.custom-screensaver-aerial.yml:

Package Metadata

✅ Check passed.

Compatibility Check

App webos.custom-screensaver-aerial

Skip because this component is not native

All OK

@mariotaku
Copy link
Member

Hi @aabytt, thanks for the submission. There are a few things I'm concerned about:

  1. I think it's better to use your own package name prefix instead of org.webosbrew.
  2. Since the resources are linking to non-free resources, this app may better suit in non-free pool.

@aabytt
Copy link
Contributor Author

aabytt commented May 29, 2024

  1. I think it's better to use your own package name prefix instead of org.webosbrew.

Sure, will do

  1. Since the resources are linking to non-free resources, this app may better suit in non-free pool.

Could not find whether linked resources are non-free. Many github screensaver projects use them. Do you think it is better to unlink the app and resources leaving a user possibility to download resources with own link?

@mariotaku
Copy link
Member

Oh I see! The assets are externally linked so the second concern isn't a problem anymore :)

@aabytt
Copy link
Contributor Author

aabytt commented May 30, 2024

  1. I think it's better to use your own package name prefix instead of org.webosbrew.

Hey @mariotaku, prefix changed

@mariotaku mariotaku merged commit 4d36521 into webosbrew:main May 30, 2024
4 checks passed
@mariotaku
Copy link
Member

Thanks. Very cool app!

@mariotaku
Copy link
Member

P.S. Could you add some screenshot to the descriptions? It looks very cool and would be better if the users can see it in the descriptions.

@aabytt
Copy link
Contributor Author

aabytt commented May 30, 2024

To add screenshots I need to PR an updated .yml file, right?

@mariotaku
Copy link
Member

@aabytt Yes, exactly. Also I could help you make the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants