Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to shivammathur/setup-php@2.9.0 #741

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Update to shivammathur/setup-php@2.9.0 #741

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f1c272
Update to shivammathur/setup-php@2.9.0
Kingdutch Nov 27, 2020
c24be8e
Update to shivammathur/setup-php@2.9.0
Kingdutch Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- uses: actions/checkout@v2

- name: Install PHP
uses: shivammathur/setup-php@2.2.2
uses: shivammathur/setup-php@2.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, ever since I've been using setup-php it's been extremely stable and the author is very diligent. Aka never have I experienced issues by just using setup-php@2 and benefit from minor updates on the fly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup but 💩 happens, I guess it's better to lock to minor at least to have reproducible builds.

with:
php-version: ${{ matrix.php }}
coverage: none
Expand Down