PHPStan level 7

[spawnia]

No description provided.

[simPod]

wow btw

[spawnia]

@simPod anything else before I 🚢 ?

[simPod]

[shmax]

Nice one, way to kill it 👍

[GromNaN]

Why the value is not a float in the FloatValueNode ?
Same for IntValueNode. For BooleanValueNode this is fine, the value is a boolean.

[spawnia]

In the case of BooleanValueNode, the PHP type can accurately represent all possible values. However, that is not the case for IntValueNode or FloatValueNode - the PHP types are limited in their range, whereas the GraphQL AST is not (see https://spec.graphql.org/draft/#sec-Int-Value - it can be an arbitrarily long sequence of digits, PHP int is limited to 32 bytes).

Scalar types are based upon those value nodes and impose certain restrictions (see https://spec.graphql.org/draft/#sec-Int), which allows us to parse incoming values of Int to a native PHP int (see

graphql-php/src/Type/Definition/IntType.php

Lines 70 to 81 in 7a78690

	public function parseLiteral(Node $valueNode, ?array $variables = null): int
	{
	if ($valueNode instanceof IntValueNode) {
	$val = (int) $valueNode->value;
	if ($valueNode->value === (string) $val && $val >= self::MIN_INT && $val <= self::MAX_INT) {
	return $val;
	}
	}
	$notInt = Printer::doPrint($valueNode);
	throw new Error("Int cannot represent non-integer value: {$notInt}", $valueNode);
	}

). There may be other numeric scalar types based on the AST literal IntValueNode which do not fit a PHP int, e.g. BigInt.