Allow to pass a thunk as a message factory to assertions #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
force-pushed
the
lazy
branch
2 times, most recently
from
f1379a5
to
48fb067
Compare
simPod
commented
Oct 29, 2020
| * @param mixed $value | ||
| * @param string $message | ||
| * @param mixed $value | ||
| * @param string|callable():string $message |
There was a problem hiding this comment.
I did not implement it to all assertions. If RFC is accepted, I'll add it everywhere
|
What would be the real life use case scenario for this? |
|
Sometimes my error messages are
so I'd rather skip that for happy path. |
simPod
force-pushed
the
lazy
branch
3 times, most recently
from
9069da3
to
397b0a4
Compare
It is useful in order to delay generating a message. At the moment the assertion does not pass the message is generated. Otherwise the thunk is not executed.
|
@BackEndTea Hi, is there a will to add lazy messages? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful in order to delay generating a message.
At the moment the assertion does not pass the message is generated. Otherwise the thunk is not executed.