Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about interop issues with clamp()'s minValue == maxValue #684

Merged
merged 1 commit into from
May 9, 2024

Conversation

inexorabletash
Copy link
Contributor

@inexorabletash inexorabletash commented May 9, 2024

Per discussion in the issue, now that XNNPACK is updated there are no backends that disallow minValue == maxValue, so the issue can be resolved and spec note can be removed.

Resolves #396


Preview | Diff

Per discussion in the issue, now that XNNPACK is updated there are no
backends that disallow minValue == maxValue, so the issue can be
resolved and spec note can be removed.

Resolves webmachinelearning#396
@inexorabletash inexorabletash requested a review from fdwr May 9, 2024 18:59
@inexorabletash
Copy link
Contributor Author

@fdwr - trivial, just trying to clean things up before the next WG telecon. Can you review & merge? thx!

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks JB.

@fdwr fdwr merged commit 103647c into webmachinelearning:main May 9, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request May 9, 2024
…684)

SHA: 103647c
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash inexorabletash deleted the remove-clamp-note branch May 9, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify the restriction for minValue and maxValue of MLClampOptions
2 participants