Swap parameters of scalar constant() operand method #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make MLGraphBuilder's constant() operand-vending methods consistent and take the data type as the first parameter. This implicitly makes the type required instead of optional. Use of constant() in decompositions are updated as well, and now use "input" consistently instead of "x" sometimes. Fixes webmachinelearning#475
|
FYI, I ran |
|
I'm going to drop this to "draft" to take it off people's radar. This would be a breaking change for lots of content, so we'll want to approach it carefully. |
|
I didn't realize until last week that Chromium didn't implement the scalar version of constant(), so this should be safe to change - no content should be relying on it, right? |
zolkis
reviewed
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make MLGraphBuilder's constant() operand-vending methods consistent and take the data type as the first parameter. This implicitly makes the type required instead of optional.
Use of constant() in decompositions are updated as well, and now use "input" consistently instead of "x" sometimes.
Fixes #475
Preview | Diff