Skip to content

Commit

Permalink
Use execFileSync to clean up (#80)
Browse files Browse the repository at this point in the history
execSync just started a second ssh-agent. `['-k']` argument was
treated as options, it didn't have `stdio` set, so stdio was piped and
returned (and ignored).
  • Loading branch information
maciejp-ro committed Jun 11, 2021
1 parent 81d965f commit a45226b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 2 additions & 3 deletions cleanup.js
@@ -1,12 +1,11 @@
const core = require('@actions/core');
const { execSync } = require('child_process');
const { execFileSync } = require('child_process');
const { sshAgent } = require('./paths.js');

try {
// Kill the started SSH agent
console.log('Stopping SSH agent');
execSync(sshAgent, ['-k'], { stdio: 'inherit' });

execFileSync(sshAgent, ['-k'], { stdio: 'inherit' });
} catch (error) {
console.log(error.message);
console.log('Error stopping the SSH agent, proceeding anyway');
Expand Down
5 changes: 2 additions & 3 deletions dist/cleanup.js
Expand Up @@ -123,14 +123,13 @@ module.exports = require("child_process");
/***/ (function(__unusedmodule, __unusedexports, __webpack_require__) {

const core = __webpack_require__(470);
const { execSync } = __webpack_require__(129);
const { execFileSync } = __webpack_require__(129);
const { sshAgent } = __webpack_require__(972);

try {
// Kill the started SSH agent
console.log('Stopping SSH agent');
execSync(sshAgent, ['-k'], { stdio: 'inherit' });

execFileSync(sshAgent, ['-k'], { stdio: 'inherit' });
} catch (error) {
console.log(error.message);
console.log('Error stopping the SSH agent, proceeding anyway');
Expand Down

0 comments on commit a45226b

Please sign in to comment.