Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use available Cucumber tag feature for Allure label instead of Feature name #9727

Conversation

valfirst
Copy link
Contributor

@valfirst valfirst commented Feb 7, 2023

Backport of #9721.

Proposed changes

When Cucumber tag feature is presented at scenario or feature level it should be used as Allure label feature value for Allure test case (now it's always equal to Cucumber Feature name)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Feb 7, 2023
@christian-bromann christian-bromann merged commit 1d4b7e7 into webdriverio:v7 Feb 7, 2023
@valfirst valfirst deleted the use-cucumber-tag-feature-for-allure-label-if-available-v7 branch February 8, 2023 06:06
@valfirst
Copy link
Contributor Author

valfirst commented Feb 8, 2023

@christian-bromann would it be possible to release a new version that includes these changes?

@christian-bromann
Copy link
Member

Sure, please stay tuned for that and watch the release tab.

@valfirst
Copy link
Contributor Author

valfirst commented Feb 9, 2023

@christian-bromann thank you for 8.x release, would it be possible to release 7.x as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants