Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Cucumber tags with special names to Allure links #9633

Conversation

valfirst
Copy link
Contributor

Backport of #9630.

Proposed changes

Cucumber tags are converted to Allure labels. In turn Allure labels with special names (like issue, testId) are converted to Allure links. But there is a gap here: Cucumber tags converted to Allure labels are not resulted in links. The goal of this PR is to eliminate this gap.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@valfirst valfirst force-pushed the map-cucumber-tags-with-special-names-to-allure-links-v7 branch from 41db693 to 9c90306 Compare January 19, 2023 22:23
@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Jan 19, 2023
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit 0e7e7da into webdriverio:v7 Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: New Feature 🚀 PRs that contain new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants