Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select default service when env is selected #9629

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Select default service when env is selected #9629

merged 1 commit into from
Jan 19, 2023

Conversation

agarneha1331
Copy link
Contributor

@agarneha1331 agarneha1331 commented Jan 19, 2023 •
edited

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@agarneha1331
Copy link
Contributor Author

This PR is same as #9477, just for the v7 branch.

christian-bromann
christian-bromann approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit 51cbcc4 into webdriverio:v7 Jan 19, 2023
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Jan 19, 2023
@agarneha1331 agarneha1331 deleted the v7_bstack_changes branch April 6, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agarneha1331 @christian-bromann