-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backward compatibility for node 12,13 #9492
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the changes that manually update the package versions. This happens automatically as part of the release
Reverted |
Can we add |
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 👍
For windows it's failed due to a test look like flaky test) it('should allow to check for PWA', async () => { |
dependand bot had changed fs-extra from ^10.0.0 to ^11.1.0 for wdio7 but fs-extra ^11.1.0 support only node>=14 the pull request change version fs-extra back to ^10.0.0 for backward compatibility with node 12,13
Proposed changes
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers