Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backward compatibility for node 12,13 #9492

Merged
merged 4 commits into from
Dec 30, 2022
Merged

backward compatibility for node 12,13 #9492

merged 4 commits into from
Dec 30, 2022

Conversation

udarrr
Copy link
Member

@udarrr udarrr commented Dec 30, 2022

dependand bot had changed fs-extra from ^10.0.0 to ^11.1.0 for wdio7 but fs-extra ^11.1.0 support only node>=14 the pull request change version fs-extra back to ^10.0.0 for backward compatibility with node 12,13

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 30, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: udarrr / name: Siarhei Kliushnikau (fb6004a)

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes that manually update the package versions. This happens automatically as part of the release

@udarrr
Copy link
Member Author

udarrr commented Dec 30, 2022

Reverted

@christian-bromann
Copy link
Member

Can we add fs-extra to the ignore list so we don't accidentally update it again? See https://github.com/webdriverio/webdriverio/blob/v7/.github/dependabot.yml#L10-L17

@udarrr
Copy link
Member Author

udarrr commented Dec 30, 2022

Added

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@udarrr
Copy link
Member Author

udarrr commented Dec 30, 2022

For windows it's failed due to a test look like flaky test)

it('should allow to check for PWA', async () => {

@christian-bromann christian-bromann merged commit bba53d6 into webdriverio:v7 Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants