Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: mark session as failed if no specs ran v7 #9471

Merged
merged 1 commit into from
Dec 28, 2022
Merged

update: mark session as failed if no specs ran v7 #9471

merged 1 commit into from
Dec 28, 2022

Conversation

Ankit098
Copy link
Contributor

when there is an error in the test script on cli there would be a failure message but the session on browserstack would get marked as passed, addressing this

Proposed changes

Mark session as failed in the above case.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@Ankit098
update: mark session as failed if no specs ran
e0fe945 
when there is an error in the test script on cli there would be a failure message but the session on browserstack would get marked as passed, addressing this
@Ankit098 Ankit098 mentioned this pull request Dec 28, 2022
Merged
8 tasks
@Ankit098 Ankit098 changed the title update: mark session as failed if no specs ran update: mark session as failed if no specs ran v7 Dec 28, 2022
christian-bromann
christian-bromann approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Dec 28, 2022
@christian-bromann christian-bromann merged commit e731fe8 into webdriverio:v7 Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ankit098 @christian-bromann