Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URLs for webauthn extension capabilities #9161

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Fix URLs for webauthn extension capabilities #9161

merged 1 commit into from
Nov 10, 2022

Conversation

ericparton
Copy link
Contributor

Proposed changes

This is a follow on to issue #8354. The pull request for that issue fixed one of the endpoints used by the webauthn capabilities, but there were several more that still have incorrect URLs per the specification. The incorrect URLs appear to be causing a number of unknown command errors when we try to use the webauthn capabilities.

I've set the URLs to the values defined in the specification.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

there are no tests in the Protocol Package so have not added any tests

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 10, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ericparton / name: Eric Parton (5dbe5d3)

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, totally didn't see that other endpoints required update as well. Thanks for fixing.

Mind raising the same PR for the v7 branch so we can release it?

@christian-bromann christian-bromann merged commit 8e8df50 into webdriverio:main Nov 10, 2022
@ericparton
Copy link
Contributor Author

Argh, totally didn't see that other endpoints required update as well. Thanks for fixing.

Mind raising the same PR for the v7 branch so we can release it?

sure, I created the new pull request #9177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants