Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@wdio/utils: revert fix for #8126 #8278

Closed
wants to merge 1 commit into from
Closed

@wdio/utils: revert fix for #8126 #8278

wants to merge 1 commit into from

Conversation

erwinheitzman
Copy link
Member

Proposed changes

Revert fix for #8126 as it causes all assertions to fail.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

CLA Not Signed

@christian-bromann
Copy link
Member

@erwinheitzman can we revert the whole commit?

@erwinheitzman
Copy link
Member Author

Sure but I am in a hurry right now so I'm not sure when I can do so

@christian-bromann
Copy link
Member

Closing in favor of #8300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants