Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import config types rather than using namespaces #8166

Merged
merged 1 commit into from Mar 29, 2022

Conversation

christian-bromann
Copy link
Member

Proposed changes

It is not recommended anymore to use global namespaces. Many projects have switched back to have users import types directly as it is more safe this way. This patch ensures this happens in the wdio.conf.ts when initiating a new project.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann requested a review from a team March 29, 2022 10:53
@christian-bromann christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Mar 29, 2022
@christian-bromann christian-bromann merged commit b82ae64 into main Mar 29, 2022
@christian-bromann christian-bromann deleted the cb-ts-config-import branch March 29, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Polish 💅 PRs that contain improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant