Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain custom commands end with $ #8134

Merged
merged 2 commits into from Mar 21, 2022
Merged

Chain custom commands end with $ #8134

merged 2 commits into from Mar 21, 2022

Conversation

jayrepo
Copy link
Contributor

@jayrepo jayrepo commented Mar 21, 2022

Proposed changes

Chaining custom command ends with $, #8043

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Further comments

Reviewers: @webdriverio/project-committers

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 21, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

christian-bromann
christian-bromann approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 👍

@christian-bromann christian-bromann added PR: Polish 💅 PRs that contain improvements on existing features PR: New Feature 🚀 PRs that contain new features and removed PR: Polish 💅 PRs that contain improvements on existing features labels Mar 21, 2022
@christian-bromann christian-bromann merged commit d9ef72f into webdriverio:main Mar 21, 2022
@yopasa94 yopasa94 mentioned this pull request Jun 9, 2022
Closed
3 tasks
@erwinheitzman erwinheitzman mentioned this pull request Oct 17, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
PR: New Feature 🚀 PRs that contain new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jayrepo @christian-bromann