Fix for rule keyowrd not working 'Cannot use Rule keyword in Cucumber… #7153
Conversation
|
@christian-bromann i am flattening the rule array , do we need to show the rule name in report ? should we preserve the rule array |
There was a problem hiding this comment.
@praveendvd I would say the Rule keyword should wrap containing scenarios, so given a Gherkin file like:
@tag
Feature: Feature
Background: Background
Given I do stuff
Rule: Only something
Scenario: Doing something
Given I do even more stuffShould create the following spec output:
------------------------------------------------------------------
[chrome 91.0.4472.114 mac os x #0-0] Running: chrome (v91.0.4472.114) on mac os x
[chrome 91.0.4472.114 mac os x #0-0] Session ID: a540510b6d7d4173283777165cdb353c
[chrome 91.0.4472.114 mac os x #0-0]
[chrome 91.0.4472.114 mac os x #0-0] » /mocha/mocha.test.js
[chrome 91.0.4472.114 mac os x #0-0] Feature
[chrome 91.0.4472.114 mac os x #0-0] Only Something
[chrome 91.0.4472.114 mac os x #0-0] Doing something
[chrome 91.0.4472.114 mac os x #0-0] ✓ Given I do even more stuff
[chrome 91.0.4472.114 mac os x #0-0]
[chrome 91.0.4472.114 mac os x #0-0] 1 passing (1.7s)
Does this make sense?
| const rules = feature.children.filter((child)=> Object.keys(child)[0]=== 'rule') | ||
| feature.children = feature.children.filter((child)=> Object.keys(child)[0]!== 'rule') |
There was a problem hiding this comment.
| const rules = feature.children.filter((child)=> Object.keys(child)[0]=== 'rule') | |
| feature.children = feature.children.filter((child)=> Object.keys(child)[0]!== 'rule') | |
| const rules = feature.children.filter((child) => Object.keys(child)[0] === 'rule') | |
| feature.children = feature.children.filter((child) => Object.keys(child)[0] !== 'rule') |
is child always an object with one property? Why do we always want to access the first key?
There was a problem hiding this comment.
First key is either rule or scenario always
|
|
||
| const rules = feature.children.filter((child)=> Object.keys(child)[0]=== 'rule') | ||
| feature.children = feature.children.filter((child)=> Object.keys(child)[0]!== 'rule') | ||
| const rulesChildrens:any = rules.map((child)=>child.rule?.children).flat() |
There was a problem hiding this comment.
| const rulesChildrens:any = rules.map((child)=>child.rule?.children).flat() | |
| const rulesChildrens = rules.map((child) => child.rule?.children).flat() |
There was a problem hiding this comment.
maybe it makes sense to change the line to rules.filter((child) => child.rule).map((child) => child.rule?.children).flat()?
Otherwise, it's possible to have an array of undefined values in case there is no child.rule
There was a problem hiding this comment.
@mgrybyk rules will have rule , the structure is like { rules : rule :children}, if there is no rules , rules will be an empty array the child won't be iterated.
There was a problem hiding this comment.
Let's don't use .? in such case child.rule
There was a problem hiding this comment.
@mgrybyk true , i will check the type for it . IT was giving type script error thank you :)
christian-bromann
added
the
needs-review
|
@praveendvd why closing the PR? |
Wanted to investigate how to propagate the rule name to the report do you want to keep the pr open till then ? @christian-bromann |
|
Yeah, no reason to close it. |
Added missing assignment
christian-bromann
added
PR: Polish 💅
… tests #7140'
Proposed changes
Allows to use Rule keyword in cucumber feature file
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers
@christian-bromann