-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11473] Refactor wdio-allure-reporter package for better hooks handling [v8] #12855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code has been restructured across the wdio-allure-reporter package for enhanced handling of hooks in different situations. Additionally, constant names and util function names have been updated for increased clarity. The handling of hooks particularly for mocha tests has been revised, improving the accuracy of test reports. Signed-off-by: Lara, Manuel <lararojas.mr@gmail.com> (cherry picked from commit 2bc28ba) Signed-off-by: Lara, Manuel <lararojas.mr@gmail.com>
13 tasks
This update modifies the wdio-allure-reporter package to better handle errors during test execution. If a step or substep fails, the error message and stack trace are now recorded for the current test. In addition, conditional logging for failed hooks has been implemented, and changes have been made to ensure the correct number of test results are recorded in suite tests. Signed-off-by: Lara, Manuel <lararojas.mr@gmail.com>
@christian-bromann when this ticket is plan to be merge? Just to know 😀 thanks |
christian-bromann
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
christian-bromann
added
the
PR: Polish 💅
PRs that contain improvements on existing features
label
May 15, 2024
when is plan to be released @christian-bromann? |
I can cut a release today. |
It was released? |
Closed
3 tasks
@lararojasmr sorry for the delay, I just triggered a v8 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code has been restructured across the wdio-allure-reporter package for enhanced handling of hooks in different situations. Additionally, constant names and util function names have been updated for increased clarity. The handling of hooks particularly for mocha tests has been revised, improving the accuracy of test reports.
(cherry picked from commit 2bc28ba)
Proposed changes
Types of changes
Checklist
Backport Request
//: # (The current
main
branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8
branch.)v9
and doesn't need to be back-ported#XXXXX
Further comments
Reviewers: @webdriverio/project-committers