-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Selenium downloadFile command #12778
Add Selenium downloadFile command #12778
Conversation
06f273f
to
254ccc6
Compare
Thanks for raising the PR!
Yes please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments
254ccc6
to
b8d2242
Compare
@christian-bromann I've made the changes you suggested. Please check again. For Safari, it doesn't seem like this feature is available. I've tried to setup local grid on my mac and noticed that Safari didn't have the download capability like the other 3 browsers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more comments.
3a0d47b
to
72ad429
Compare
@christian-bromann better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Mind providing the same PR for the |
@ccharnkij mind rebasing the branch? |
8ade7a3
to
0147540
Compare
Thanks again for helping us backport this feature. |
Proposed changes
This change adds all 3 of Selenium Grid download command. For downloadFile, the logic is pretty much straight from Selenium JS binding
Types of changes
Checklist
Further comments
If needed and this is good, I can make the same change for main as well.
#12671
Reviewers: @webdriverio/project-committers