Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[馃挕 Feature]: Update WebAuthn WebDriver Extension Capabilities #8354

Closed
1 task done
christian-bromann opened this issue May 18, 2022 · 2 comments
Closed
1 task done

[馃挕 Feature]: Update WebAuthn WebDriver Extension Capabilities #8354

christian-bromann opened this issue May 18, 2022 · 2 comments
Labels
Bug 馃悰 Expensable $25 馃捀 help wanted Issues that are free to take by anyone interested Protocol Related

Comments

@christian-bromann
Copy link
Member

Is your feature request related to a problem?

The Web Authentication Working Group has defined WebDriver endpoints for automating WebAuthn standard capabilities. The webdriver package has these already implemented but it seems the endpoints have changed between v1 and v2 of the spec.

Describe the solution you'd like.

  • Check if WebAuthn v1 is still relevant and remove endpoints if necessary
  • Add/Update WebAuthn v2 endpoints

A reference implementation can be found in the Selenium project: SeleniumHQ/selenium#10663

Describe alternatives you've considered.

n/a

Additional context

n/a

Code of Conduct

  • I agree to follow this project's Code of Conduct
@christian-bromann christian-bromann added help wanted Issues that are free to take by anyone interested Protocol Related Idea 馃挕 A new feature idea Expensable $25 馃捀 labels May 18, 2022
@christian-bromann
Copy link
Member Author

After talking to Puja Jagani from the Selenium team in appears that the protocol endpoints haven't changed. However they are not correctly implemented in the @wdio/protocols package: /session/:sessionId/authenticator vs /session/{session id}/webauthn/authenticator.

@christian-bromann christian-bromann added Bug 馃悰 and removed Idea 馃挕 A new feature idea labels May 18, 2022
@joshskumar joshskumar mentioned this issue May 28, 2022
Merged
5 tasks
christian-bromann pushed a commit that referenced this issue May 30, 2022
@joshskumar
Fix for bug #8354 (#8379)
7ac4026 
* The nano to milli second conversion was wrong so updated it

* extension is a string array accoring to W3 APIs but here it is defined as array of Object

* Endpoint needs to be corrected as well so made the changes as per the document
@christian-bromann
Copy link
Member Author

Closing as this got fixed by @joshskumar , thank you!

This was referenced Nov 10, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 馃悰 Expensable $25 馃捀 help wanted Issues that are free to take by anyone interested Protocol Related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@christian-bromann