Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer registerCustomQueryHandler API #43

Merged
merged 4 commits into from
Dec 4, 2020
Merged

Puppeteer registerCustomQueryHandler API #43

merged 4 commits into from
Dec 4, 2020

Conversation

cladelpino
Copy link
Contributor

Since https://openbase.io/js/puppeteer-core/versions#5.4.0 , the registerCustomQueryHandler API is no longer experimental

Since https://openbase.io/js/puppeteer-core/versions#5.4.0 , the registerCustomQueryHandler API is no longer experimental
Since https://openbase.io/js/puppeteer-core/versions#5.4.0 , the registerCustomQueryHandler API is no longer experimental
Since https://openbase.io/js/puppeteer-core/versions#5.4.0 , the registerCustomQueryHandler API is no longer experimental
Since https://openbase.io/js/puppeteer-core/versions#5.4.0 , the registerCustomQueryHandler API is no longer experimental
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #43 (5495d11) into master (98fd91a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           74        74           
=========================================
  Hits            74        74           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98fd91a...5495d11. Read the comment docs.

@Georgegriff
Copy link
Contributor

Thanks for the pr, puppeteer has built in shadow Dom support now I should probably but this on the docs

@Georgegriff Georgegriff merged commit 50871f0 into webdriverio:master Dec 4, 2020
@cladelpino
Copy link
Contributor Author

wow, I wasn't able to make it work in vainilla puppeteer, neither can I find it in their docs.. any link ?

your project saved that situation for me instantly so thanks a lot !!

@Georgegriff
Copy link
Contributor

Glad to hear it was useful! They haven't documented the feature, which is strange! Perhaps that deserves an issue with Puppeteer, the only reference to it was in release notes and this pr

puppeteer/puppeteer#6509

It looks to be an in built custom query handler that uses the word 'pierce' as its name. So replacing the custom query handler name from my examples with that name should work

If you try it out, please let me know how you get on, would be interested so I can just point people at that in my read me as an official alternative

@cladelpino cladelpino deleted the patch-1 branch December 5, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants