The GIF attached to an issue is broken after the issue has been reported

[cipriansv]

Steps to reproduce:

1. Navigate to: https://webcompat.com/issues/new
2. Report an issue with an attached GIF.
3. Observe the GIF rendering.

Expected Behavior:
The GIF must be displayed with no rendering issues.

Actual Behavior:
The GIF is broken. See issue #21981.

Notes:

1. The issue is reproducible on Chrome 70.0.3538.110

Watchers:
@softvision-oana-arbuzov
@softvision-sergiulogigan
@cipriansv

sv;

[magsout]

@cipriansv thanks for the report.

What do you mean by The GIF is broken ? I tried on Chrome and Firefox and I don't see any issue?

[softvision-sergiulogigan]

@magsout check out the GIF attachment of webcompat/web-bugs#21981

[magsout]

@softvision-sergiulogigan oh got it.

Same gif, but the first was filled directly withing the webcompat form and the second within a comment on Github, right?

[softvision-sergiulogigan]

@magsout yup

[karlcow]

Probably related to #1024

I need to check if pillow has improved on the animated GIF side of things.

[karlcow]

We are currently using Pillow==5.2.0

The current version is 5.4.1

Ah I see that in 4.1.0 something was changed with regards to GIF and Palettes.

The code is here.

webcompat.com/webcompat/api/uploads.py

Lines 96 to 124 in 2e90cb2

	def save(self):
	'''Check that the file is allowed, then save to filesystem.'''
	save_parameters = {}
	if self.file_ext not in self.ALLOWED_FORMATS:
	raise TypeError('Image file format not allowed')
	# Paths of the images
	file_dest = app.config['UPLOADS_DEFAULT_DEST'] + self.image_path
	thumb_dest = app.config['UPLOADS_DEFAULT_DEST'] + self.thumb_path
	dest_dir = os.path.dirname(file_dest)
	if not os.path.exists(dest_dir):
	os.makedirs(dest_dir)
	# Alpha channels are not supported in JPEG
	if (self.image_object.format == 'PNG'):
	self.image_object = self.image_object.convert('RGB')
	# Optimize further the image compression for these formats
	if self.image_object.format in ['JPEG', 'JPG', 'JPE', 'PNG']:
	save_parameters['optimize'] = True
	# Convert PNG to JPEG. See issue #1051
	file_dest = 'jpg'.join(file_dest.rsplit('png', 1))
	# If animated GIF, aka duration > 0, add save_all parameter
	if (self.image_object.format == 'GIF' and
	self.image_object.info['duration'] > 0):
	save_parameters['save_all'] = True
	# unpacking save_parameters
	self.image_object.save(file_dest, **save_parameters)
	# Creating the thumbnail
	size = (1024, 1024)
	self.image_object.thumbnail(size, Image.HAMMING)
	self.image_object.save(thumb_dest, **save_parameters)

[karlcow]

<a
  href="https://webcompat.com/uploads/2018/11/93e4a08e-aa43-4bd5-85b9-f50e3a73cb7b.gif"
  rel="nofollow"
  ><img
    src="https://camo.githubusercontent.com/e14dfdd6cf740863938dd16731ed7df0882ee4ff/68747470733a2f2f776562636f6d7061742e636f6d2f75706c6f6164732f323031382f31312f39336534613038652d616134332d346264352d383562392d6635306533613733636237622d7468756d622e676966"
    alt="Screenshot Description"
    data-canonical-src="https://webcompat.com/uploads/2018/11/93e4a08e-aa43-4bd5-85b9-f50e3a73cb7b-thumb.gif"
    style="max-width:100%;"
/></a>

how come the image is on GitHub… It is supposed to be on webcompat.com.

• https://webcompat.com/uploads/2018/11/93e4a08e-aa43-4bd5-85b9-f50e3a73cb7b-thumb.gif
• https://webcompat.com/uploads/2018/11/93e4a08e-aa43-4bd5-85b9-f50e3a73cb7b.gif

I need to test with some gifs.

[karlcow]

ok I checked most of the animated gif uploaded in 2018. All of them have a broken palette of colors.
There is something to fix there (if we can).

[karlcow]

Yeah still not solved on Pillow side. python-pillow/Pillow#2893

[karlcow]

In fact a lot of issues :)
https://github.com/python-pillow/Pillow/issues?q=is%3Aissue+is%3Aopen+gif+label%3A%22Palette+Issue%22