Convert serial/synchronous rounds to parallel/asynchronous rounds (#301) #302
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Thomas Braun <93542359+tpbraun96@users.noreply.github.com> Co-authored-by: Drew Stone <drewstone329@gmail.com> Co-authored-by: Dustin Brickwood <dustinbrickwood204@gmail.com>
|
Linting with Linting with clippy works when we use: |
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
- Coverage 41.67% 40.14% -1.53%
==========================================
Files 72 73 +1
Lines 5006 4743 -263
==========================================
- Hits 2086 1904 -182
+ Misses 2920 2839 -81
Continue to review full report at Codecov.
|
|
The reason why |
The issue is that WASM cannot access File I/O, and as such, it cannot access the underlying file descriptors required by async programming. Custom socket opts are requires for libp2p since NAT traversal, depending on the technique, requires Regardless, it appears now that only 1 test is failing. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 279 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 153 | 4 | 122 | 0 |
Click to see the invalid file list
- dkg-gadget/src/messages/dkg_message.rs
- dkg-gadget/src/meta_async_rounds/dkg_gossip_engine/mock.rs
- dkg-gadget/src/meta_async_rounds/dkg_gossip_engine/mod.rs
- dkg-gadget/src/meta_async_rounds/dkg_gossip_engine/network.rs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
license-eye has totally checked 268 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 145 | 3 | 120 | 0 |
Click to see the invalid file list
- standalone/node/src/command.rs
- standalone/node/src/command_helper.rs
- standalone/node/src/rpc.rs
There was a problem hiding this comment.
license-eye has totally checked 268 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 145 | 3 | 120 | 0 |
Click to see the invalid file list
- standalone/node/src/command.rs
- standalone/node/src/command_helper.rs
- standalone/node/src/rpc.rs
There was a problem hiding this comment.
license-eye has totally checked 268 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 145 | 3 | 120 | 0 |
Click to see the invalid file list
- standalone/node/src/command.rs
- standalone/node/src/command_helper.rs
- standalone/node/src/rpc.rs
|
@dutterbutter can you fix the link errors on this branch? |
|
@drewstone yes no problem |
* Minimal P2P Reputation * keep track of message duplicate * tests working Co-authored-by: Shady Khalifa <shekohex@gmail.com>
Co-authored-by: Shady Khalifa <dev+github@shadykhalifa.me>
* add more logs and debug info * remove tokio-console for now
Co-authored-by: drewstone <drewstone329@gmail.com>
* try not to sign if we are not in the current best set * Bump threshold in chain_spec * update the logs and emit events with more info * try to rotate locally if the key on-chain is same as the local queued key * another bug we found * check with prev dkg key too * Restore worker.rs * Restore lib.rs * Restore lib.rs * fix the bug in counting bytes manually * Fix change authorities threshold updates * Fixes to race on proposal sign/next keygen * Bump signing set limit Co-authored-by: drewstone <drewstone329@gmail.com>
shekohex
added
feature ➕
No description provided.