Fix sort-comp ClassExpression

Fixes jsx-eslint#1076. Also adds test.
webOS101 · Feb 21, 2017 · ab1631d · ab1631d
1 parent 22f3638
commit ab1631d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/rules/sort-comp.js b/lib/rules/sort-comp.js
@@ -291,6 +291,7 @@ module.exports = {
      */
     function getComponentProperties(node) {
       switch (node.type) {
+        case 'ClassExpression':
         case 'ClassDeclaration':
           return node.body.body;
         case 'ObjectExpression':

diff --git a/tests/lib/rules/sort-comp.js b/tests/lib/rules/sort-comp.js
@@ -286,6 +286,20 @@ ruleTester.run('sort-comp', rule, {
     ].join('\n'),
     parserOptions: parserOptions,
     errors: [{message: 'render should be placed after onClick'}]
+  }, {
+    // Must force a custom method to be placed before render, even in function
+    code: [
+      'var Hello = () => {',
+      '  return class Test extends React.Component {',
+      '    render () {',
+      '      return <div>Hello</div>;',
+      '    }',
+      '    onClick () {}',
+      '  }',
+      '};'
+    ].join('\n'),
+    parserOptions: parserOptions,
+    errors: [{message: 'render should be placed after onClick'}]
   }, {
     // Must force a custom method to be placed after render if no 'everything-else' group is specified
     code: [