Release/1.8.1 #5577

jdevcs · 2022-10-28T12:31:40Z

Fixed

Fixed types for getPastEvents (Update index.d.ts #4955) (Update index.d.ts #5260)
Fix Log type by adding missing removed property (Add removed property to Log type #4877)

Changed

Updated dependencies (Update 1.x Dependencies #5529)

coveralls · 2022-10-28T12:47:56Z

Pull Request Test Coverage Report for Build 3438017874

0 of 0 changed or added relevant lines in 0 files are covered.
269 unchanged lines in 7 files lost coverage.
Overall coverage increased (+2.3%) to 74.555%

Files with Coverage Reduction	New Missed Lines	%
packages/web3-core-requestmanager/src/jsonrpc.js	2	64.29%
packages/web3-core-helpers/src/formatters.js	8	84.3%
packages/web3-core-helpers/src/errors.js	29	1.56%
packages/web3-utils/src/soliditySha3.js	34	3.43%
packages/web3-utils/src/index.js	40	40.3%
packages/web3-utils/src/utils.js	45	10.67%
packages/web3-eth-accounts/src/index.js	111	23.05%

Totals
Change from base Build 3419711499:	2.3%
Covered Lines:	3281
Relevant Lines:	4145

💛 - Coveralls

jdevcs · 2022-10-28T13:12:01Z

As part of the RC process, following test installations are performed in other projects and running their tests to see if everything.

installs properly
builds
tests pass

(This list will be actively edited)

Project	Desc	Status
oz-test-helpers	Test utils. Subset of their suite is web3 contracts
synthetix	~1000 units

jdevcs · 2022-10-28T13:47:48Z

@Muhammad-Altabba and @luu-alex , Could you check Synthetix & OZ tests and update table above. Thanks

luu-alex · 2022-10-31T17:10:29Z

Project	Desc	Status
[oz-test-helpers][1]	Test utils. Subset of their suite is web3 contracts	✅
[synthetix][2]	~1000 units	✅

oz-test-helpers passed with no errors, synthetix tests had no new errors.
looks good

Muhammad-Altabba · 2022-11-08T11:41:04Z

@Muhammad-Altabba and @luu-alex , Could you check Synthetix & OZ tests and update table above. Thanks

Cloning oz-test-helpers and linking to this version of web3 produced the following new error:

  1) Contract: balance
       current
         returns the current balance of an account as a BN in a specified unit:
     Error: Invalid character
      at assert (/home/maltabba/repos/web3v1.x/node_modules/bn.js/lib/bn.js:6:21)
      at parseBase (/home/maltabba/repos/web3v1.x/node_modules/bn.js/lib/bn.js:274:7)
      at BN._parseBase (/home/maltabba/repos/web3v1.x/node_modules/bn.js/lib/bn.js:298:14)
      at BN.init [as _init] (/home/maltabba/repos/web3v1.x/node_modules/bn.js/lib/bn.js:105:14)
      at new BN (/home/maltabba/repos/web3v1.x/node_modules/bn.js/lib/bn.js:39:12)
      at new BNwrapped (/home/maltabba/repos/web3v1.x/packages/web3-utils/lib/utils.js:480:16)
      at Object.balanceCurrent [as current] (src/balance.js:40:10)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/balance.test.js:17:14)

However, there are other 2 errors that are shown with both this RC and the previous versions (checked with 1.8.0 and 1.2.5). Those errors are:

  2) expectRevert
       assertion
         rejects an outOfGas:
     AssertionError: expect.fail()
      at assertFailure (test/helpers/assertFailure.js:9:10)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/expectRevert.test.js:123:7)

  3) expectRevert
       outOfGas
         accepts an outOfGas:

      Wrong kind of exception received
      + expected - actual

      -Transaction: 0xafa2b1b036c974b23e8c76ce348a4e17eca272f767490372ae9df5c634823e57 exited with an error (status 0) after consuming all gas.
      -     Please check that the transaction:
      -     - satisfies all conditions set by Solidity `assert` statements.
      -     - has enough gas to execute the full transaction.
      -     - does not trigger an invalid opcode by other means (ex: accessing an array out of bounds).
      +out of gas
      
      at expectException (src/expectRevert.js:20:30)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/expectRevert.test.js:153:7)

I am using the last version of Ganache.

@luu-alex Did you face similar issues

luu-alex · 2022-11-08T16:26:07Z

@Muhammad-Altabba I believe its similar, the contract: balance failing test persists 1.8.0 and 1.8.1 rc and might need investigation next update

Running against openzeppelin tests with 1.8.1 rc:


  253 passing (2m)
  2 failing

  1) Contract: balance
       current
         returns the current balance of an account as a BN in a specified unit:
     Error: Invalid character
      at assert (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:6:21)
      at parseBase (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:274:7)
      at BN._parseBase (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:298:14)
      at BN.init [as _init] (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:105:14)
      at new BN (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:39:12)
      at new BNwrapped (node_modules/web3-utils/lib/utils.js:480:16)
      at Object.balanceCurrent [as current] (src/balance.js:33:10)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/balance.test.js:20:19)

  2) expectRevert
       "before each" hook for "rejects if no revert occurs":
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/alexluu/openzeppelin-test-helpers/test/src/expectRevert.test.js)
      at listOnTimeout (node:internal/timers:559:17)
      at processTimers (node:internal/timers:502:7)

Running against 1.8.0 open zeppelin

 274 passing (1m)
  1 failing

  1) Contract: balance
       current
         returns the current balance of an account as a BN in a specified unit:
     Error: Invalid character
      at assert (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:6:21)
      at parseBase (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:274:7)
      at BN._parseBase (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:298:14)
      at BN.init [as _init] (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:105:14)
      at new BN (node_modules/web3-utils/node_modules/bn.js/lib/bn.js:39:12)
      at new BNwrapped (node_modules/web3-utils/lib/utils.js:480:16)
      at Object.balanceCurrent [as current] (src/balance.js:33:10)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/balance.test.js:20:19)

jdevcs · 2022-11-10T14:46:03Z

@Muhammad-Altabba I believe its similar, the contract: balance failing test persists 1.8.0 and 1.8.1 rc and might need investigation next update

These tests should be investigated in next release #5609

jdevcs added 3 commits October 28, 2022 16:54

npm i npm audit fix and changelog update

49dae94

v1.8.1-rc.0

b9b8a0c

Manual build commit for 1.8.1-rc.0

751d85b

jdevcs added Release 1.x 1.0 related issues labels Oct 28, 2022

jdevcs requested a review from a team October 28, 2022 12:31

jdevcs self-assigned this Oct 28, 2022

jdevcs marked this pull request as ready for review October 28, 2022 13:31

luu-alex approved these changes Oct 31, 2022

View reviewed changes

nikoulai self-requested a review November 7, 2022 12:36

nikoulai approved these changes Nov 7, 2022

View reviewed changes

jdevcs added 2 commits November 10, 2022 19:08

v1.8.1

b3fd92e

Build for 1.8.1

65d27a5

jdevcs changed the title ~~Release/1.8.1-rc.0~~ Release/1.8.1 Nov 10, 2022

jdevcs mentioned this pull request Nov 10, 2022

OZ tests investigation #5609

Closed

Merge branch '1.x' into release/1.8.1

4bf9f5b

jdevcs merged commit 3b22adf into 1.x Nov 10, 2022

This was referenced Mar 20, 2023

[Snyk] Upgrade web3-core from 1.7.1 to 1.8.2 skeps-org/web3.js#1

Open

[Snyk] Upgrade web3-utils from 1.7.1 to 1.8.2 skeps-org/web3.js#2

Open

[Snyk] Upgrade web3-core-method from 1.7.1 to 1.8.2 skeps-org/web3.js#3

Open

snyk-bot mentioned this pull request Mar 20, 2023

[Snyk] Upgrade web3-eth2-core from 1.7.1 to 1.8.2 skeps-org/web3.js#4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/1.8.1 #5577

Release/1.8.1 #5577

jdevcs commented Oct 28, 2022

coveralls commented Oct 28, 2022 •

edited

jdevcs commented Oct 28, 2022

jdevcs commented Oct 28, 2022

luu-alex commented Oct 31, 2022 •

edited

Muhammad-Altabba commented Nov 8, 2022

luu-alex commented Nov 8, 2022 •

edited

jdevcs commented Nov 10, 2022

Release/1.8.1 #5577

Release/1.8.1 #5577

Conversation

jdevcs commented Oct 28, 2022

Fixed

Changed

coveralls commented Oct 28, 2022 • edited

Pull Request Test Coverage Report for Build 3438017874

💛 - Coveralls

jdevcs commented Oct 28, 2022

jdevcs commented Oct 28, 2022

luu-alex commented Oct 31, 2022 • edited

Muhammad-Altabba commented Nov 8, 2022

luu-alex commented Nov 8, 2022 • edited

jdevcs commented Nov 10, 2022

coveralls commented Oct 28, 2022 •

edited

luu-alex commented Oct 31, 2022 •

edited

luu-alex commented Nov 8, 2022 •

edited