Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'0x' strings returned by contract are incorrectly interpreted as nulls #4730

Merged
merged 4 commits into from Jan 27, 2022

Conversation

nazarhussain
Copy link
Contributor

Description

Fix the encoding error for the string values.

Fixes #4512

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@render
Copy link

render bot commented Jan 25, 2022

@coveralls
Copy link

coveralls commented Jan 25, 2022

Pull Request Test Coverage Report for Build 1744571215

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 265 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.4%) to 75.087%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 70.0%
packages/web3-core-helpers/src/formatters.js 7 85.42%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 43 31.38%
packages/web3-utils/src/utils.js 44 9.66%
packages/web3-eth-accounts/src/index.js 107 23.67%
Totals Coverage Status
Change from base Build 1740453311: 2.4%
Covered Lines: 3255
Relevant Lines: 4103

💛 - Coveralls

@nazarhussain nazarhussain marked this pull request as ready for review January 25, 2022 09:15
@nazarhussain nazarhussain self-assigned this Jan 25, 2022
@nazarhussain nazarhussain added the 1.x 1.0 related issues label Jan 25, 2022
@nazarhussain nazarhussain merged commit 8d2d49c into 1.x Jan 27, 2022
@nazarhussain nazarhussain deleted the 4512-0x-string-decoding branch January 27, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'0x' strings returned by contract are incorrectly interpreted as nulls
4 participants