Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make web3.js compatible with Content Security Policy and Trusted Types #4729

Closed
wants to merge 2 commits into from
Closed

Make web3.js compatible with Content Security Policy and Trusted Types #4729

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3542ef7
Alter use of CSP & TT incompatible eval()
Zemnmez Jan 25, 2022
5550ca8
Merge branch 'ChainSafe:1.x' into attempt-trusted-types-fix
Zemnmez Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 23 additions & 6 deletions packages/web3-core-requestmanager/src/givenProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,31 @@

var givenProvider = null;

const getGlobal = () => {
if (typeof globalThis !== 'undefined') { return globalThis }
if (typeof self !== 'undefined') { return self; }
if (typeof global !== 'undefined') { return global; }
if (typeof window !== 'undefined') { return window; }

// This eval() will cause a Trusted Types / Content Security Policy failure
// in browsers that support it, on websites that have *also* have these
// controls enabled.
//
// The chance of this occurring is next to nil, as `window` would have to be
// deleted and `globalThis` would have to be unsupported, as well as the
// browser having support for the modern security controls detecting this
// unsafe usage:
//
// https://caniuse.com/contentsecuritypolicy,mdn-javascript_builtins_globalthis
//
// In these browsers, there is no eval() safe way of getting a reference to the
// global object when these conditions occur.
return Function('return this')();
}

// ADD GIVEN PROVIDER
/* jshint ignore:start */
var global;
try {
global = Function('return this')();
} catch (e) {
global = window;
}
var global = getGlobal();

// EIP-1193: window.ethereum
if (typeof global.ethereum !== 'undefined') {
Expand Down