[text-box-trim] Fix when there is an initial-letter #46277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5540990
branch
from
b60e575
to
20e6bfd
Compare
`text-box-trim` is supposed to trim all parts above the point specified by the `text-box-edge`. This patch fixes initial letter boxes preventing the trimming, similar to crrev.com/c/5539108 fixed for the Ruby annotation. This patch has no behavior changes as the changes are under a runtime flag. Bug: 40254880 Change-Id: I7741f6a78e34371959d4ab3ca9cb8a5a9a2a8460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540990 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Lingqi Chi <lingqi@chromium.org> Reviewed-by: Lingqi Chi <lingqi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1301161}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5540990
branch
from
20e6bfd
to
767f575
Compare
wpt-pr-bot
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text-box-trimis supposed to trim all parts above the pointspecified by the
text-box-edge. This patch fixes initialletter boxes preventing the trimming, similar to
crrev.com/c/5539108 fixed for the Ruby annotation.
This patch has no behavior changes as the changes are under a
runtime flag.
Bug: 40254880
Change-Id: I7741f6a78e34371959d4ab3ca9cb8a5a9a2a8460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540990
Auto-Submit: Koji Ishii <kojii@chromium.org>
Commit-Queue: Lingqi Chi <lingqi@chromium.org>
Reviewed-by: Lingqi Chi <lingqi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1301161}