Check thread id is in current frames #46266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Chromium Windows bot, we are seeing KeyError below. Check the thread
id is in sys._current_frames() before format_stack, otherwise do not
include the stack in the error message.
Error message:
00:02:16.943 WARNING: Exception in TestExecutor.run:
File "C:\b\s\w\ir\third_party\wpt_tools\wpt\tools\wptrunner\wptrunner\executors\base.py", line 219, in run
message += "".join(traceback.format_stack(sys._current_frames()[executor.ident]))
KeyError: 8372
wpt-pr-bot
added
infra
wptrunner
|
/infrastructure/testdriver/actions/multiTouchPointsSimultaneousMove.html The failure on infrastructure/ tests is not related with this change. |
jonathan-j-lee
approved these changes
May 15, 2024
|
@KyleJu can you help admin merge? Thanks! |
KyleJu
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Chromium Windows bot, we are seeing KeyError as below. Check the thread id is in sys._current_frames() before format_stack, otherwise do not include the stack in the error message.
Error message:
00:02:16.943 WARNING: Exception in TestExecutor.run:
File "C:\b\s\w\ir\third_party\wpt_tools\wpt\tools\wptrunner\wptrunner\executors\base.py", line 219, in run
message += "".join(traceback.format_stack(sys._current_frames()[executor.ident]))
KeyError: 8372