Make showPicker() consume user activation #44181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5235516
branch
2 times, most recently
from
ef110a1
to
3b78e40
Compare
Allowing the page to call showPicker() on select elements as much as it wants without consuming user activation may result in the user being unable to interact with the browser UI due to popups always taking focus. The HTML spec also says to do this for input elements, so I added code to do it there as well. This patch also modified the select showPicker test because calling showPicker on a select twice in a row in the test somehow resulted in blink not seeing any input events on the second test_driver.bless(), perhaps because the select's popup is still open and is somehow intercepting the input. HTML spec: whatwg/html#10344 Bug: 1521345 Fixed: 343302069, 343093082, 343473478 Change-Id: If6308a67bac9050f695d18d275ea86c23ac22b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5235516 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1309009}
wpt-pr-bot
approved these changes
Jun 1, 2024
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5235516
branch
from
3b78e40
to
73f7e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the page to call showPicker() on select elements as much as it
wants without consuming user activation may result in the user being
unable to interact with the browser UI due to popups always taking
focus.
The HTML spec also says to do this for input elements, so I added code
to do it there as well.
This patch also modified the select showPicker test because calling
showPicker on a select twice in a row in the test somehow resulted in
blink not seeing any input events on the second test_driver.bless(),
perhaps because the select's popup is still open and is somehow
intercepting the input.
HTML spec: whatwg/html#10344
Bug: 1521345
Fixed: 343302069, 343093082, 343473478
Change-Id: If6308a67bac9050f695d18d275ea86c23ac22b0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5235516
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1309009}