Skip to content

Commit

Permalink
[bfcache] Rename reasons to match the spec
Browse files Browse the repository at this point in the history
This CL renames the reporting strings of NotRestoredReasons API so that
they match the spec draft[1].

[1]: whatwg/html#10154

Bug: 331754704
Change-Id: If805ad7e30c14ff64b440c8d9515eaee38370fd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5392283
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1280059}
  • Loading branch information
rubberyuzu authored and chromium-wpt-export-bot committed Mar 29, 2024
1 parent 4f6add9 commit e99b818
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ promise_test(async t => {

// Check the BFCache result and the reported reasons.
await assertBFCacheEligibility(rc1, /*shouldRestoreFromBFCache=*/ false);
await assertNotRestoredFromBFCache(rc1, ['navigation-failure']);
await assertNotRestoredFromBFCache(rc1, ['response-status-not-ok']);
});
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ promise_test(async t => {
await openWebRTC(rc1);
// The page should not be eligible for BFCache because of open WebRTC connection and live MediaStreamTrack.
await assertBFCacheEligibility(rc1, /*shouldRestoreFromBFCache=*/ false);
await assertNotRestoredFromBFCache(rc1, ['webrtc', 'media-stream']);
await assertNotRestoredFromBFCache(rc1, ['rtc', 'mediastream']);
});

0 comments on commit e99b818

Please sign in to comment.