Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add check-dependency-version #6323

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

SoonIter
Copy link
Member

Summary

#5477

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 1f8d8b3
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/662c767beab7530008b2b950

@chenjiahan
Copy link
Member

@SoonIter can you resolve the conflicts and fix the CI~

@SoonIter SoonIter marked this pull request as draft April 26, 2024 08:21
@chenjiahan
Copy link
Member

can you resolve the conflicts and CI again ❤️

@SoonIter
Copy link
Member Author

SoonIter commented May 9, 2024

can you resolve the conflicts and CI again ❤️

sorry, i almost forgot it, delayed by phantom dependence problem and react multiple versions...

separate the bench case from dependency graph might be better, but it needs the refactor of benchmark

@chenjiahan
Copy link
Member

separate the bench case from dependency graph might be better

The bench case need to use workspace:* protocol to reference the local Rspack, so it may not be separated from the workspace.

Can this dependency issue be solved with a different approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants