Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix: remove @types/webpack-sources and add declaration of webpack-sources (close: #5867) #5868

Closed
wants to merge 1 commit into from

Conversation

Amour1688
Copy link
Contributor

@Amour1688 Amour1688 commented Mar 6, 2024

Summary

fix #5867

Require Documentation?

  • No
  • Yes, the corresponding rspack-website PR is __

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Mar 6, 2024
@LingyuCoder LingyuCoder requested a review from ahabhgk March 6, 2024 06:53
@Amour1688 Amour1688 force-pushed the fix-webpack-sources-type branch 2 times, most recently from 067e7d4 to 6f9b06c Compare March 6, 2024 06:58
@Amour1688 Amour1688 force-pushed the fix-webpack-sources-type branch 2 times, most recently from 5b738a0 to 3e79e6b Compare March 6, 2024 11:25
@Amour1688 Amour1688 changed the title fix: move @types/webpack-sources to dependencies (close: #5867) fix: fix: remove @types/webpack-sources and add declaration of webpack-sources (close: #5867) Mar 6, 2024
@alfaproject
Copy link

Why not fix/contribute the types in https://github.com/DefinitelyTyped/DefinitelyTyped

@chenjiahan
Copy link
Member

Agreed, we should contribute to @types/webpack-sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: the type of webpack-sources is any
5 participants