feat: optimization.chunkIds supports 'natural' #5104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OceanPresentChao
requested review from
ahabhgk,
hyf0 and
h-a-n-a
as code owners
github-actions
bot
added
the
release: feature
|
I keep the default value of chunkIds & moduleIds as they used to be, because the change of default value leads to changes in the output file name, failing in some test cases. |
style: clippy fix: revert test config fix: revert default moduleIds
OceanPresentChao
force-pushed
the
issue4823
branch
2 times, most recently
from
9d117c6
to
4a680e4
Compare
OceanPresentChao
force-pushed
the
issue4823
branch
from
4a680e4
to
94a12ca
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. If this pull request is still relevant, please leave any comment (for example, "bump"). |
|
Thanks for your contribution so much and sorry for not responding. The Welcome your future contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
issue: issue4823
This Plugin supports 'natural' in optimization.moduleIds and optimization.chunkIds, aligning with webpack
Test Plan
run test in packages/rspack/test/optimization/natural-chunks & natural-modules
Require Documentation?