Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port ImportMetaPlugin of Webpack #2684

Merged
merged 7 commits into from Apr 11, 2023
Merged

feat: port ImportMetaPlugin of Webpack #2684

merged 7 commits into from Apr 11, 2023

Conversation

underfin
Copy link
Collaborator

@underfin underfin commented Apr 10, 2023 •
edited

Summary

  • Port webpack ImportMetaPlugin

Related issue (if exists)

close #2392

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023 •
edited

⚠️ No Changeset found

Latest commit: 04bb88e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 10, 2023
9aoy
9aoy previously approved these changes Apr 10, 2023
View reviewed changes
@underfin underfin enabled auto-merge April 10, 2023 11:56
@underfin underfin added this pull request to the merge queue Apr 11, 2023
Merged via the queue into main with commit 1b58008 Apr 11, 2023
6 checks passed
@underfin underfin deleted the import-env branch April 11, 2023 07:20
@ahabhgk ahabhgk linked an issue Apr 11, 2023 that may be closed by this pull request
support compile import.meta.url #729
Closed
@hyf0 hyf0 changed the title feat: import meta scanner feat: port ImportMetaPlugin of Webpack Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a left review comments

@ahabhgk ahabhgk ahabhgk approved these changes

@9aoy 9aoy 9aoy left review comments

@hardfist hardfist Awaiting requested review from hardfist

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees

@h-a-n-a h-a-n-a

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report]: cannot use 'import.meta' outside a module support compile import.meta.url
5 participants
@underfin @h-a-n-a @9aoy @ahabhgk @hyf0