Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): using official react-refresh-webpack-plugin #1831

Merged

Conversation

chenjiahan
Copy link
Member

PR Details

Description

Switch back to the official react-refresh-webpack-plugin package.

Ref: #1808

Also removed some changesets of @modern-js/webpack-builder because this package is renamed.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated changeset
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022

⚠️ No Changeset found

Latest commit: 1f8d98c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 57.17% // Head: 57.17% // No change to project coverage 👍

Coverage data is based on head (1f8d98c) compared to base (e20ff5c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1831   +/-   ##
=======================================
  Coverage   57.17%   57.17%           
=======================================
  Files         626      626           
  Lines       15969    15969           
  Branches     3400     3400           
=======================================
  Hits         9130     9130           
  Misses       6312     6312           
  Partials      527      527           
Impacted Files Coverage Δ
...s/cli/webpack/src/config/features/react-refresh.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sanyuan0704 sanyuan0704 merged commit d27f93a into web-infra-dev:main Oct 11, 2022
@chenjiahan chenjiahan deleted the official_react_refresh_plugin_1010 branch October 11, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants