Add Flux OCI support #358
Closed
Add Flux OCI support #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 2, 2022 18:13
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
This basically works 🎉 - [X] OCI Source nodes in source tree view - [X] OCI Source hover text shows minimum information - [ ] OCI Source hover text shows all relevant fields - [X] Right click context entries work for OCI sources - [ ] Create Source workflow includes OCIRepository kind - [ ] Kustomizations with OCIRepository sources are tested Signed-off-by: Kingdon Barrett <kingdon@weave.works>
One of these will be set at least, or the OCIRepository should default to pulling the 'latest' tag (which is fine if you like, sure, but that would not be GitOps anymore...) Signed-off-by: Kingdon Barrett <kingdon@weave.works>
|
The outstanding work items that remain from #355 and off the top of my head to complete here are:
|
added 3 commits
August 2, 2022 22:59
The flux cli from "Build Flux OCI Binary (Pre-release)" can be used to test against a Flux with the new OCI support. Signed-off-by: Kingdon Barrett <kingdon@weave.works>
(it should be possible for us to push a prerelease that is tested against the new oci release and exercises the features) Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
|
This one can close, it was superseded by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #309
This is released in an edge build, so far it seems like there are no issues with backward or forward compatibility.
Component PRs:
Testers needed! Please review
kingdonb/podinfo, we have these GitHub Actions workflows for example:fluxCLI binaryfluxcli to runflux push- change this to work however you wantIf your architecture or OS is different than CI you may also need to clone fluxcd/flux2, checkout from the
ocibranch, and runmaketo build the CLI for your workstation. (Otherwise, you can retrieve a CLI binary that is built from CI, it is published only once as a build artifact on the first "Build Flux OCI Binary (Pre-release)" build job that runs. It will be rebuilt again if the prereleaseocibranch is changed.)It is expected for this workflow to vary slightly until we can solidify the guidance around how to use the new OCI feature more, and provide more concrete examples or even a "Flux cookbook."
See also (the
fluxcd/flux2branchoci) where this workflow derives the prerelease Flux binary from:This is WIP (but basically finished now) and can merge after the next Flux minor release series has landed, v0.32.x.