Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prometehus client exemplar panic #246

Closed
wants to merge 1 commit into from

Conversation

liguozhong
Copy link

@liguozhong liguozhong commented Jul 12, 2022

fix: grafana/loki#6667

const ExemplarMaxRunes = 64

	prometheus.Labels{"traceID": "008e1a5aa9165763983789310049f851"},

Runes = 39,just one traceId label ,no more label should be add.

image

@bboreham
Copy link
Collaborator

Thanks for this; sorry I didn't get to it sooner.
I merged #247 instead, which is a clean removal; I preferred that over commented-out code.

@bboreham bboreham closed this Jul 19, 2022
@liguozhong
Copy link
Author

Thanks for this; sorry I didn't get to it sooner. I merged #247 instead, which is a clean removal; I preferred that over commented-out code.

No matter which PR is merged as long as it can solve the problem, this problem really bothered me last week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: exemplar labels have 85 runes, exceeding the limit of 64
2 participants