Update sanctuary-scripts to version 3.x #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avaq
force-pushed
the
avaq/scripts
branch
2 times, most recently
from
edb550a
to
cc9ba40
Compare
|
Grrr. Coveralls is being an 🥚 again |
|
This is what's happening in the build-server. I don't yet understand why. $ npm run coverage
> react-collect@1.0.3 coverage /home/travis/build/wearereasonablepeople/react-collect
> nyc report --reporter=text-lcov | coveralls
[error] "2019-03-22T09:49:40.232Z" 'error from lcovParse: ' 'Failed to parse string'
[error] "2019-03-22T09:49:40.234Z" 'input: ' ''
[error] "2019-03-22T09:49:40.234Z" 'error from convertLcovToCoveralls'
/home/travis/build/wearereasonablepeople/react-collect/node_modules/coveralls/bin/coveralls.js:18
throw err;
^
Failed to parse string |
|
Found the related issue: nickmerwin/node-coveralls#207 |
|
That leads to a bug in node v11; but we've been using v10 all this time. |
|
It doesn't work on any of the node versions I've tried:
It doesn't work with any of the nyc versions I've tried:
It doesn't work with any of the coveralls versions I've tried:
|
Avaq
force-pushed
the
avaq/scripts
branch
2 times, most recently
from
d971e4e
to
381b57e
Compare
|
@paolobueno checks passed! :) |
paolobueno
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To keep dependencies up to date and close #12
Changes
opening-delimiteroption added to configure what sanctuary-scripts sees as code blocksscripts/testcould be removed because sanctuary-scripts supports mjs files now