Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Workload Benchmark Plots #5364

Open
wants to merge 11 commits into
base: 4.8.0
Choose a base branch
from
Open

Fix Workload Benchmark Plots #5364

wants to merge 11 commits into from

Conversation

rafabailon
Copy link
Member

@rafabailon rafabailon commented May 13, 2024 •
edited

Description

The data used to generate the plots are now obtained from the API. Because of this, the plots are not being generated correctly, as the data and column names have changed.

Related to https://github.com/wazuh/wazuh-jenkins/issues/6203

Testing performed

OS Package used
Debian 10 Manager
Validation Jenkins
The pipeline execution ends correctly 馃煝
Check that the plots have been generated 馃煝

Build:

@rafabailon rafabailon self-assigned this May 13, 2024
@rafabailon
Copy link
Member Author

Update

I have created a copy of the pipeline for testing purposes. In the default values, I have left all the necessary values checked so that, with a single run, the results of all the changes can be seen.

https://ci.wazuh.info/view/Tests_DEV/job/CLUSTER-Workload_benchmarks_metrics_6203/

I am reviewing the rest of the code to see if there is anything else to adapt to avoid, as much as possible, having to run several tests.

@rafabailon
Copy link
Member Author

Update

In the file deps/wazuh_testing/wazuh_testing/tools/performance/statistic_headers.py is the list of all the columns that are received from the API. I have checked and compared the data in that file with the data used to generate the plots.

@rafabailon
Copy link
Member Author

Update

After running the pipeline https://ci.wazuh.info/view/Tests_DEV/job/CLUSTER-Workload_benchmarks_metrics_6203/1/ it seems that the logcollector plots appear but the rest of the folders are still empty. Further investigation is necessary.

@rafabailon
Copy link
Member Author

rafabailon commented May 15, 2024 •
edited

Results

Build: https://ci.wazuh.info/view/Tests_DEV/job/CLUSTER-Workload_benchmarks_metrics_6203/11/

@rafabailon rafabailon marked this pull request as ready for review May 15, 2024 15:42
@rafabailon
Copy link
Member Author

Results

All plots are generated correctly

Build: https://ci.wazuh.info/view/Tests_DEV/job/CLUSTER-Workload_benchmarks_metrics_6203/13/

@rafabailon rafabailon force-pushed the enhancement/6203-adapt-workload-benchmar-plots-to-api-format branch from 91a413c to a176f0a Compare May 17, 2024 13:47
@rafabailon rafabailon force-pushed the enhancement/6203-adapt-workload-benchmar-plots-to-api-format branch from a176f0a to fcbe8c1 Compare May 17, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santipadilla santipadilla santipadilla approved these changes

Assignees

@rafabailon rafabailon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rafabailon @santipadilla