Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wazo 2894 allow cloning subdirectory and archived sources #56

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sopelj
Copy link

@sopelj sopelj commented Oct 20, 2022

No description provided.

@wazo-community-zuul
Copy link
Contributor

Build failed.

@sopelj sopelj force-pushed the WAZO-2894-allow-cloning-subdirectory branch from d89c7bc to 5285695 Compare October 20, 2022 17:41
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@@ -114,6 +120,7 @@ class OptionField(fields.Field):

_options = {
'git': fields.Nested(GitInstallOptionsSchema),
'archive': fields.Nested(ArchiveInstallOptionsSchema),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, does the archive option is intended to be merged in master? (i.e. part of the spec of plugind?)
Or it's only for the POC?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should have created this as a draft, I'll change it. It's a test for provd-plugins. I was trying to test a few different ways the plugins could be built and distributed. Installing via git currently requires a separate repo per plugin, hence the test with sub directories and the archive option was if we need to build plugins in the CI still, creating and archive to download is easy and doesn't need to be committed in the repo. So far just for testing though.

@sopelj sopelj changed the title Wazo 2894 allow cloning subdirectory and Archive sources Wazo 2894 allow cloning subdirectory and archived sources Oct 24, 2022
@sduthil sduthil marked this pull request as draft January 13, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants