Fix wait_imp on windows

watchexec · Dec 26, 2022 · 4a773d3 · 4a773d3
1 parent 3b3211d
commit 4a773d3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/stdlib/child/windows.rs b/src/stdlib/child/windows.rs
@@ -10,7 +10,7 @@ use winapi::{
 	},
 	um::{
 		handleapi::CloseHandle, ioapiset::GetQueuedCompletionStatus, jobapi2::TerminateJobObject,
-		minwinbase::LPOVERLAPPED, winbase::INFINITE, winnt::HANDLE,
+		minwinbase::OVERLAPPED, winbase::INFINITE, winnt::HANDLE,
 	},
 };
 
@@ -70,21 +70,22 @@ impl ChildImp {
 	fn wait_imp(&self, timeout: DWORD) -> Result<()> {
 		let mut code: DWORD = 0;
 		let mut key: ULONG_PTR = 0;
-		let mut overlapped = mem::MaybeUninit::<LPOVERLAPPED>::uninit();
+		let mut overlapped = mem::MaybeUninit::<OVERLAPPED>::uninit();
+		let mut lp_overlapped = overlapped.as_mut_ptr();
 
 		let result = unsafe {
 			GetQueuedCompletionStatus(
 				self.handles.completion_port,
 				&mut code,
 				&mut key,
-				overlapped.as_mut_ptr(),
+				&mut lp_overlapped,
 				timeout,
 			)
 		};
 
 		// ignore timing out errors unless the timeout was specified to INFINITE
 		// https://docs.microsoft.com/en-us/windows/win32/api/ioapiset/nf-ioapiset-getqueuedcompletionstatus
-		if timeout != INFINITE && result == FALSE && overlapped.as_ptr().is_null() {
+		if timeout != INFINITE && result == FALSE && lp_overlapped.is_null() {
 			return Ok(());
 		}
 

diff --git a/src/tokio/child/windows.rs b/src/tokio/child/windows.rs
@@ -10,7 +10,7 @@ use winapi::{
 	},
 	um::{
 		handleapi::CloseHandle, ioapiset::GetQueuedCompletionStatus, jobapi2::TerminateJobObject,
-		minwinbase::LPOVERLAPPED, winbase::INFINITE, winnt::HANDLE,
+		minwinbase::OVERLAPPED, winbase::INFINITE, winnt::HANDLE,
 	},
 };
 
@@ -70,21 +70,22 @@ impl ChildImp {
 	fn wait_imp(handles: JobPort, timeout: DWORD) -> Result<()> {
 		let mut code: DWORD = 0;
 		let mut key: ULONG_PTR = 0;
-		let mut overlapped = mem::MaybeUninit::<LPOVERLAPPED>::uninit();
+		let mut overlapped = mem::MaybeUninit::<OVERLAPPED>::uninit();
+		let mut lp_overlapped = overlapped.as_mut_ptr();
 
 		let result = unsafe {
 			GetQueuedCompletionStatus(
 				handles.completion_port,
 				&mut code,
 				&mut key,
-				overlapped.as_mut_ptr(),
+				&mut lp_overlapped,
 				timeout,
 			)
 		};
 
 		// ignore timing out errors unless the timeout was specified to INFINITE
 		// https://docs.microsoft.com/en-us/windows/win32/api/ioapiset/nf-ioapiset-getqueuedcompletionstatus
-		if timeout != INFINITE && result == FALSE && overlapped.as_ptr().is_null() {
+		if timeout != INFINITE && result == FALSE && lp_overlapped.is_null() {
 			return Ok(());
 		}