Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and re-enable temporarily skipped tests #4604

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix and re-enable temporarily skipped tests #4604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
124dc7b
tests: Fix text comparison in test
theduke Apr 25, 2024
5dc4966
tests: Re-enable temporarily skipped tests
theduke Apr 25, 2024
1046b5e
tests: Use pretty_assertions for better comparison output
theduke Apr 25, 2024
05a9381
ci: Re-enable CLI integration tests
theduke Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ jobs:
run: |
make untar-wasmer
- name: Test integration CLI
if: false # matrix.build != 'macos-arm'
if: matrix.build != 'macos-arm'
shell: bash
run: |
export WASMER_PATH=`pwd`/target/${{ matrix.target }}/release/wasmer${{ matrix.exe }}
Expand Down
2 changes: 2 additions & 0 deletions tests/integration/cli/tests/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
use std::path::Path;

use pretty_assertions::assert_eq;

use assert_cmd::Command;
use predicates::str::contains;
use tempfile::TempDir;
Expand Down
4 changes: 1 addition & 3 deletions tests/integration/cli/tests/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,9 +357,7 @@ fn run_test_caching_works_for_urls() {
// Got a cache hit downloading the *.webc file's metadata
.stderr(contains("web_source: Cache hit"))
// Cache hit downloading the *.webc file
.stderr(contains(
r#"builtin_loader: Cache hit! pkg.name="python" pkg.version=0.1.0"#,
))
.stderr(contains(r#"builtin_loader: Cache hit! pkg=python@0.1.0"#))
// Cache hit compiling the module
.stderr(contains("module_cache::filesystem: Cache hit!"));
}
Expand Down
4 changes: 0 additions & 4 deletions tests/integration/cli/tests/snapshot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,7 +1152,6 @@ fn test_snapshot_dash_dev_urandom() {

#[cfg_attr(any(target_env = "musl", target_os = "windows"), ignore)]
#[test]
#[ignore = "must be re-enabled after backend deployment"]
fn test_snapshot_dash_dash() {
let snapshot = TestBuilder::new()
.with_name(function!())
Expand All @@ -1164,7 +1163,6 @@ fn test_snapshot_dash_dash() {

#[cfg_attr(any(target_env = "musl", target_os = "windows"), ignore)]
#[test]
#[ignore = "must be re-enabled after backend deployment"]
fn test_snapshot_dash_bash() {
let snapshot = TestBuilder::new()
.with_name(function!())
Expand Down Expand Up @@ -1231,7 +1229,6 @@ fn test_snapshot_bash_python() {

#[cfg_attr(any(target_env = "musl", target_os = "windows"), ignore)]
#[test]
#[ignore = "must be re-enabled after backend deployment"]
fn test_snapshot_bash_bash() {
let snapshot = TestBuilder::new()
.with_name(function!())
Expand All @@ -1243,7 +1240,6 @@ fn test_snapshot_bash_bash() {

#[cfg_attr(any(target_env = "musl", target_os = "windows"), ignore)]
#[test]
#[ignore = "must be re-enabled after backend deployment"]
fn test_snapshot_bash_dash() {
let snapshot = TestBuilder::new()
.with_name(function!())
Expand Down