Experimental: Add interpreter support for Wasmer #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
commented
Mar 25, 2024
Comment on lines
+151
to
+154
| #[cfg_attr( | ||
| feature = "wasm-c-api", | ||
| ignore = "wasm-c-api has a different memory testuite" | ||
| )] |
There was a problem hiding this comment.
We can probably remove this, since we are skipping the failing tests
syrusakbary
commented
Mar 26, 2024
| @@ -128,6 +124,7 @@ default = ["wat", "wast", "cache", "wasi", "engine", "emscripten", "middlewares" | |||
| # That means: that is able to execute modules | |||
| backend = [] | |||
| jsc = ["wasmer/jsc", "backend", "wat", "wasmer/std"] | |||
| wasm-c-api = ["wasmer/wasm-c-api", "backend", "wat", "wasmer/std"] | |||
There was a problem hiding this comment.
We should add a new one: wamr = ["wasm-c-api"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for running Wasm modules in interpreted mode (in this case, via WAMR).
Progress: