Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-c-api) wasmer_instance_call types must matche wasmer_export_func_*_arity #440

Merged
merged 8 commits into from May 14, 2019
Merged

fix(runtime-c-api) wasmer_instance_call types must matche wasmer_export_func_*_arity #440

merged 8 commits into from May 14, 2019

Commits on May 14, 2019

  1. fix(runtime-c-api) wasmer_instance_call types matches `wasmer_expor… 

    …t_func_*_arity`.

The `wasmer_export_func_params_arity` and
`wasmer_export_func_returns_arity` functions store the arity in a
`uint32_t`. The `wasmer_instance_call` expects `c_int`. There is a
type mismatch here. It's not annoying in C or C++, but in some other
languages that have bindings to C/C++, it can imply useless casting.

This patch changes `wasmer_instance_call` to expect `uint32_t` for
`params_len` and `results_len` to match the
`wasmer_export_func_*_arity` functions.
    @Hywan
    Hywan committed May 14, 2019
    Copy the full SHA
    d3c75a3 View commit details
    Browse the repository at this point in the history

  2. test(runtime-c-api) Use *_arity variables when calling `wasmer_expo… 

    …rt_func_call`.
    @Hywan
    Hywan committed May 14, 2019
    Copy the full SHA
    f68379a View commit details
    Browse the repository at this point in the history

  3. chore(runtime-c-api) Regenerate C/C++ header files.

    @Hywan
    Hywan committed May 14, 2019
    Copy the full SHA
    2b250c3 View commit details
    Browse the repository at this point in the history

  4. chore(changelog) Add wasmerio#440.

    @Hywan
    Hywan committed May 14, 2019
    Copy the full SHA
    0749932 View commit details
    Browse the repository at this point in the history

  5. fix(runtime-c-api) Update wasmer_export_func_params_arity signature. 

    The `params_len` argument type of `wasmer_export_func_params_arity`
must be `uint32_t` to match the `wasmer_export_func_*_arity` results,
so that casts are not required.
    @Hywan
    Hywan committed May 14, 2019
    Copy the full SHA
    91006ba View commit details
    Browse the repository at this point in the history

  6. chore(runtime-c-api) Update C/C++ header files.

    @Hywan
    Hywan committed May 14, 2019
    Copy the full SHA
    5366138 View commit details
    Browse the repository at this point in the history

  7. fix(runtime-c-api) Update wasmer_export_func_params_arity signature. 

    The `returns_len` argument type of `wasmer_export_func_returns_params`
must be `uint32_t` to match the `wasmer_export_func_returns_arity` results,
so that casts are not required.
    @Hywan
    Hywan committed May 14, 2019
    Copy the full SHA
    f04e773 View commit details
    Browse the repository at this point in the history

  8. chore(runtime-c-api) Update C/C++ header files.

    @Hywan
    Hywan committed May 14, 2019
    Copy the full SHA
    8bd9bbb View commit details
    Browse the repository at this point in the history