implement symlinks for virtual-fs #4062
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pirita is pivate for now, but that will change (very) soon. The PR looks ok for now, appart for the symlink behind a feature. And I see some tests already, which is good. @Michael-F-Bryan if you can also have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is PR implements symlinks for the
virtual-fscrate. It is a WIP and I'd appreciate any feedback/confirmation I'm heading in a direction that would get the implementation accepted! This would close #3232.The main chunk of work I'd like reviewed is for
mem_fs::FileSystem. I based the logic for the symlink functionality in the memory file system based on functionality I found playing around withstd::os::unix::fs::symlinkin this gist.Remaining work outside of any feedback is to implement symlink for any of the file systems using
webc::v1::Volumeas I can't seem to find the repository containing the crate (ispiritaprivate?).